lkml.org 
[lkml]   [2012]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/4] signal: give SEND_SIG_FORCED more power to beat SIGNAL_UNKILLABLE
Hello, Oleg,.

I can't provide any meaningful constructive criticism but have one
bike-shedding one.

On Fri, Feb 10, 2012 at 09:00:21PM +0100, Oleg Nesterov wrote:
> diff --git a/kernel/signal.c b/kernel/signal.c
> index c73c428..bfb2b97 100644
> --- a/kernel/signal.c
> +++ b/kernel/signal.c
> @@ -1059,7 +1059,8 @@ static int __send_signal(int sig, struct siginfo *info, struct task_struct *t,
>
> assert_spin_locked(&t->sighand->siglock);
>
> - if (!prepare_signal(sig, t, from_ancestor_ns))
> + if (!prepare_signal(sig, t,
> + from_ancestor_ns || (info == SEND_SIG_FORCED)))

How about the following indentation instead? :)

if (!prepare_signal(sig, t,
from_ancestor_ns || (info == SEND_SIG_FORCED)))

Overall, the changes look sane to me but I haven't really thought
about it deeply. Please feel free to add Reviewed-by for 2-4.

Thank you.

--
tejun


\
 
 \ /
  Last update: 2012-02-10 22:27    [W:0.047 / U:10.936 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site