Messages in this thread | | | From | Linus Torvalds <> | Date | Fri, 10 Feb 2012 11:28:27 -0800 | Subject | Re: Direct i/o changes break all non-GPL file systems |
| |
On Tue, Feb 7, 2012 at 5:51 PM, Andreas Dilger <adilger@dilger.ca> wrote: > > This doesn't affect me directly, since Lustre is itself a GPL filesystem, > but it does seem a bit harsh for such a minor amount of functionality.
It also wasn't documented in the commit or apparently even intentional.
> Looking at inode_dio_wait(), there isn't anything in there that couldn't > be implemented without using that GPL-only symbol export. Both inode_dio_wait() > and __inode_dio_wait() use only functions that are themselves EXPORT_SYMBOL() > (i.e. not GPL-only) and locally accessible structures (inode->i_dio_count > and inode->i_state), so I don't see any benefit or reason in making > inode_dio_wait() itself GPL.
Yes. I suspect we should just remove the _GPL part. Christoph, Al?
Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |