lkml.org 
[lkml]   [2012]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V1] regmap: Support for caching in reg_raw_write()
On 02/10/2012 12:32 PM, Laxman Dewangan wrote:
> Adding support for caching of data into the
> non-volatile register from the call of reg_raw_write().
>
> This will allow the larger block of data write into multiple
> register without worrying whether register is cached or not
> through reg_raw_write().
>

In my opinion it makes more sense to introduce a regmap_bulk_write function
for this. regmap_raw_write was not really meant to write registers but
rather binary blobs, like firmware. Also this keeps things consistent with
the read part of the regmap API.

> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
> ---
> drivers/base/regmap/regmap.c | 25 ++++++++++++++++++++-----
> 1 files changed, 20 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c
> index 80129c0..e5986ab 100644
> --- a/drivers/base/regmap/regmap.c
> +++ b/drivers/base/regmap/regmap.c
> @@ -323,6 +323,25 @@ static int _regmap_raw_write(struct regmap *map, unsigned int reg,
> if (!map->writeable_reg(map->dev, reg + i))
> return -EINVAL;
>
> + if (!map->cache_bypass && map->format.parse_val) {
> + int val_bytes = map->format.val_bytes;
> + unsigned int ival;
> + for (i = 0; i < val_len / map->format.val_bytes; i++) {
> + memcpy(map->work_buf, val + (i * val_bytes), val_bytes);
> + ival = map->format.parse_val(map->work_buf);
> + ret = regcache_write(map, reg + i, ival);
> + if (ret) {
> + dev_warn(map->dev,
> + "Error in caching of register\n");
> + return ret;
> + }
> + }
> + if (map->cache_only) {
> + map->cache_dirty = true;
> + return 0;
> + }
> + }
> +
> map->format.format_reg(map->work_buf, reg);
>
> u8[0] |= map->write_flag_mask;
> @@ -373,7 +392,7 @@ int _regmap_write(struct regmap *map, unsigned int reg,
> int ret;
> BUG_ON(!map->format.format_write && !map->format.format_val);
>
> - if (!map->cache_bypass) {
> + if (!map->cache_bypass && map->format.format_write) {
> ret = regcache_write(map, reg, val);
> if (ret != 0)
> return ret;
> @@ -450,12 +469,8 @@ EXPORT_SYMBOL_GPL(regmap_write);
> int regmap_raw_write(struct regmap *map, unsigned int reg,
> const void *val, size_t val_len)
> {
> - size_t val_count = val_len / map->format.val_bytes;
> int ret;
>
> - WARN_ON(!regmap_volatile_range(map, reg, val_count) &&
> - map->cache_type != REGCACHE_NONE);
> -
> mutex_lock(&map->lock);
>
> ret = _regmap_raw_write(map, reg, val, val_len);



\
 
 \ /
  Last update: 2012-02-10 13:03    [W:0.040 / U:13.356 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site