lkml.org 
[lkml]   [2012]   [Feb]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[10/20] USB: ftdi_sio: fix TIOCSSERIAL baud_base handling
    2.6.32-longterm review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Johan Hovold <jhovold@gmail.com>

    commit eb833a9e0972f60beb4ab8104ad7ef6bf30f02fc upstream.

    Return EINVAL if new baud_base does not match the current one.

    The baud_base is device specific and can not be changed. This restores
    the old (pre-2005) behaviour which was changed due to a
    misunderstanding regarding this fact (see
    https://lkml.org/lkml/2005/1/20/84).

    Reported-by: Torbjörn Lofterud <torbjorn@pi.nxs.se>
    Signed-off-by: Johan Hovold <jhovold@gmail.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/usb/serial/ftdi_sio.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    --- a/drivers/usb/serial/ftdi_sio.c
    +++ b/drivers/usb/serial/ftdi_sio.c
    @@ -1351,8 +1351,7 @@ static int set_serial_info(struct tty_st
    goto check_and_exit;
    }

    - if ((new_serial.baud_base != priv->baud_base) &&
    - (new_serial.baud_base < 9600)) {
    + if (new_serial.baud_base != priv->baud_base) {
    unlock_kernel();
    return -EINVAL;
    }

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-02-01 22:57    [W:0.022 / U:29.856 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site