Messages in this thread | | | Subject | Re: [PATCH net-next] net: dev: Convert printks to pr_<level> | From | Joe Perches <> | Date | Wed, 01 Feb 2012 11:40:29 -0800 |
| |
On Wed, 2012-02-01 at 14:21 -0500, David Miller wrote: > From: Joe Perches <joe@perches.com> > Date: Sun, 29 Jan 2012 16:20:30 -0800 > > - pr_warning("Number of in use tx queues changed " > > - "invalidating tc mappings. Priority " > > - "traffic classification disabled!\n"); > > + pr_warn( > > +"Number of in use tx queues changed invalidating tc mappings. " > > +"Priority traffic classification disabled!\n"); > Don't do things like this. It is never correct to un-indent subsequent > lines of a string like this. And a line ending in "pr_whatever(" looks > terrible.
I don't care much one way or another about it. There are a few different uses in that file already.
I do try to avoid having the compiler do string coalescing. In this case, I thought it unlikely that a person would grep with content from both sentences though.
Coalesced, this format is:
"Number of in use tx queues changed invalidating tc mappings. Priority traffic classification disabled!\n"
105 chars. That's pretty long. Do you prefer coalesced formats in all cases?
pr_warn("Number of in use tx queues changed invalidating tc mappings. Priority traffic classification disabled!\n");
| |