Messages in this thread | | | Date | Wed, 1 Feb 2012 17:24:01 +0100 | From | Maxime Coquelin <> | Subject | Re: [PATCH 1/4] mfd/ab8500: fix error path bug |
| |
Hi Linus,
On 02/01/2012 05:09 PM, Linus WALLEIJ wrote: > From: Linus Walleij<linus.walleij@linaro.org> > > We were not freeing the irq properly in the error path in > the AB8500 driver. > > Cc: Mark Brown<broonie@opensource.wolfsonmicro.com> > Signed-off-by: Maxime Coquelin<maxime.coquelin@stericsson.com> > Signed-off-by: Alex Macro<alex.macro@stericsson.com> > Signed-off-by: Michel Jaouen<michel.jaouen@stericsson.com> > Signed-off-by: Linus Walleij<linus.walleij@linaro.org> > --- > drivers/mfd/ab8500-core.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/drivers/mfd/ab8500-core.c b/drivers/mfd/ab8500-core.c > index 53e2a80..bf823d2 100644 > --- a/drivers/mfd/ab8500-core.c > +++ b/drivers/mfd/ab8500-core.c > @@ -956,9 +956,10 @@ int __devinit ab8500_init(struct ab8500 *ab8500) > return ret; > > out_freeirq: > - if (ab8500->irq_base) { > + if (ab8500->irq_base) > free_irq(ab8500->irq, ab8500); > out_removeirq: > + if (ab8500->irq_base) > ab8500_irq_remove(ab8500); > } Shouldn't the above brace to be removed? > return ret;
Regards, Maxime
| |