Messages in this thread | | | From | Sethi Varun-B16395 <> | Subject | RE: [PATCH 2/5] iommu/amd: Implement DOMAIN_ATTR_GEOMETRY attribute | Date | Wed, 1 Feb 2012 09:37:52 +0000 |
| |
> -----Original Message----- > From: iommu-bounces@lists.linux-foundation.org [mailto:iommu- > bounces@lists.linux-foundation.org] On Behalf Of Joerg Roedel > Sent: Friday, January 20, 2012 9:31 PM > To: Laurent Pinchart > Cc: Ohad Ben-Cohen; Tony Lindgren; linux-kernel@vger.kernel.org; > iommu@lists.linux-foundation.org; Wood Scott-B07421; David Brown; David > Woodhouse > Subject: Re: [PATCH 2/5] iommu/amd: Implement DOMAIN_ATTR_GEOMETRY > attribute > > On Thu, Jan 19, 2012 at 05:27:09PM +0100, Laurent Pinchart wrote: > > > Well, u64 is a catch-all datatype which should suit all drivers. Is > > > this a problem at ARM? > > > > No, it's not a problem for ARM, at least to my knowledge. It just > > struck me as weird, as we have specific data types for other kinds of > > addresses (such as dma_addr_t). > > Okay, I looked at the definition and dma_addr_t seems like a good fit. > To be consistent we should change the iova type of the map/unmap > functions to dma_addr_t too. This change is certainly required in the iommu API map/unmap calls.
-Varun
| |