Messages in this thread | | | Date | Sun, 09 Dec 2012 01:31:50 +0100 | From | Cyril Roelandt <> | Subject | Re: [PATCH] staging: rtl8712: avoid a useless call to memset(). |
| |
On 12/05/2012 08:11 AM, Dan Carpenter wrote: > On Wed, Dec 05, 2012 at 02:22:02AM +0100, Cyril Roelandt wrote: >> In r8711_wx_get_wap(), make sure we do not call memcpy() on a memory area that >> has just been zeroed by a call to memset(). >> > > I look at it like the original code is fine. Your version is also > fine but is it worth the churn? Also the curly braces are not > needed. >
Sorry about the braces.
I just thought the code would be easier to understand this way, but it's probably OK to leave it as it currently is too.
WBR, Cyril Roelandt.
| |