lkml.org 
[lkml]   [2012]   [Dec]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: rtl8712: avoid a useless call to memset().
On 12/05/2012 08:11 AM, Dan Carpenter wrote:
> On Wed, Dec 05, 2012 at 02:22:02AM +0100, Cyril Roelandt wrote:
>> In r8711_wx_get_wap(), make sure we do not call memcpy() on a memory area that
>> has just been zeroed by a call to memset().
>>
>
> I look at it like the original code is fine. Your version is also
> fine but is it worth the churn? Also the curly braces are not
> needed.
>

Sorry about the braces.

I just thought the code would be easier to understand this way, but it's
probably OK to leave it as it currently is too.

WBR,
Cyril Roelandt.


\
 
 \ /
  Last update: 2012-12-09 02:01    [W:0.066 / U:0.748 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site