lkml.org 
[lkml]   [2012]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] arch/x86/tools/gen-insn-attr-x86.awk: remove duplicate const
On 12/07/2012 03:17 PM, Cong Ding wrote:
> On Fri, Dec 07, 2012 at 03:06:13PM -0800, H. Peter Anvin wrote:
>> On 12/07/2012 03:03 PM, Cong Ding wrote:
>>> On Fri, Dec 07, 2012 at 02:56:16PM -0800, H. Peter Anvin wrote:
>>>> On 12/07/2012 02:49 PM, Cong Ding wrote:
>>>>> On Fri, Dec 07, 2012 at 02:45:43PM -0800, H. Peter Anvin wrote:
>>>>>> Patch description please?
>>>>> there are 2 consts in the definition of one variable
>>>>>
>>>>
>>>> Please put in an actual patch description. The first line (subject
>>>> line) is a title; the patch should make sense without it.
>>> sorry for that. so like this is fine?
>>>
>>
>> Well, except that typically you should explain which variable it is.
>> Yes, it is obvious if you look at the patch, but you're making the
>> reader spend a few more moments than necessary.
>>
>> Also, you should explain what the harm is -- if it breaks anything
>> or is just a cosmetic issue.
> sorry again for lacking of experience...
> and I missed another same error, so send version 2.
>

And one final complaint (I'll fix this one, but for the future):

git automation wants you to put commentary *after* the patch (after the
line with three dashes) rather than before.

-hpa

--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.



\
 
 \ /
  Last update: 2012-12-08 00:41    [W:0.190 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site