Messages in this thread | | | Date | Fri, 7 Dec 2012 23:41:10 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH V2] MCE: fix an error of mce_bad_pages statistics |
| |
On Fri, Dec 07, 2012 at 02:11:02PM -0800, Andrew Morton wrote: > A few things: > > - soft_offline_page() already checks for this case: > > if (PageHWPoison(page)) { > unlock_page(page); > put_page(page); > pr_info("soft offline: %#lx page already poisoned\n", pfn); > return -EBUSY; > }
Oh, so we do this check after all. But later in the function. Why? Why not at the beginning so that when a page is marked poisoned already we can exit early?
Strange.
-- Regards/Gruss, Boris.
| |