Messages in this thread | | | Date | Fri, 7 Dec 2012 17:52:18 +0100 | From | Andreas Mohr <> | Subject | Re: Look Ma, da kernel is b0rken |
| |
Hi,
On Wed, Dec 05, 2012 at 01:38:53PM -0800, Andrew Morton wrote: > Bjorn had a review comment which appears to remain unaddressed: > > : The original is definitely broken. > : > : I think the corrected test allows PNP IDs containing '@', which > : doesn't appear legal per sec 6.1.5 of the ACPI 5.0 spec. Should this > : be > : > : + if (!('A' <= (c) && (c) <= 'Z')) \ > : > : instead?
I hate having to rain on the parade again ;) I just developed some doubts, by accident again, by getting dangerously near sound/isa/als100.c snd_als100_pnpids: there are many IDs with '@' embedded (at least in this ISA-based PnP code), thus I guess that code may have had its justification (unless ACPI 5.0 is clearly fully authoritative for this space and thus '@' does not have any business there any more).
Dito e.g. isa/cmi8330.c.
Hmm, anyone deeply familiar with ISA PnP ID magic? :)
Andreas Mohr
| |