lkml.org 
[lkml]   [2012]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: Look Ma, da kernel is b0rken
    Hi,

    On Wed, Dec 05, 2012 at 01:38:53PM -0800, Andrew Morton wrote:
    > Bjorn had a review comment which appears to remain unaddressed:
    >
    > : The original is definitely broken.
    > :
    > : I think the corrected test allows PNP IDs containing '@', which
    > : doesn't appear legal per sec 6.1.5 of the ACPI 5.0 spec. Should this
    > : be
    > :
    > : + if (!('A' <= (c) && (c) <= 'Z')) \
    > :
    > : instead?

    I hate having to rain on the parade again ;)
    I just developed some doubts, by accident again,
    by getting dangerously near sound/isa/als100.c snd_als100_pnpids:
    there are many IDs with '@' embedded (at least in this ISA-based PnP code),
    thus I guess that code may have had its justification (unless ACPI 5.0
    is clearly fully authoritative for this space and thus '@' does not have any
    business there any more).

    Dito e.g. isa/cmi8330.c.

    Hmm, anyone deeply familiar with ISA PnP ID magic? :)

    Andreas Mohr


    \
     
     \ /
      Last update: 2012-12-07 18:41    [W:3.751 / U:0.228 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site