lkml.org 
[lkml]   [2012]   [Dec]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86: ptrace.c only needs export.h and not the full module.h
On Thu, Dec 06, 2012 at 06:33:42AM -0500, Paul Gortmaker wrote:
> Commit cb57a2b4cff7edf2a4e32c0163200e9434807e0a ("x86-32: Export
> kernel_stack_pointer() for modules") added an include of the
> module.h header in conjunction with adding an EXPORT_SYMBOL_GPL
> of kernel_stack_pointer.
>
> But module.h should be avoided for simple exports, since it in turn
> includes the world. Swap the module.h for export.h instead.

If this is the preferred include for EXPORT_SYMBOL* stuff now, maybe we
should hold this down somewhere in writing or add it to checkpatch?

Thanks.

--
Regards/Gruss,
Boris.


\
 
 \ /
  Last update: 2012-12-06 19:21    [W:0.084 / U:0.608 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site