lkml.org 
[lkml]   [2012]   [Dec]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH, 3.7-rc7, RESEND] fs: revert commit bbdd6808 to fallocate UAPI
Date
Am Montag, 26. November 2012 schrieb Dave Chinner:
> On Sun, Nov 25, 2012 at 09:55:20PM -0500, Theodore Ts'o wrote:
> > On Mon, Nov 26, 2012 at 11:28:14AM +1100, Dave Chinner wrote:
> > > fs: revert commit bbdd6808 to fallocate UAPI
> > >
> > > From: Dave Chinner <dchinner@redhat.com>
> > >
> > > Commit bbdd6808 ("fs: reserve fallocate flag codepoint") changes
> > > the fallocate(2) syscall interface. The flag that is reserved by
> > > this commit is for functionality that has previously been NAKed on
> > > the -fsdevel mailing list, and so exists out-of-tree.
> >
> > Hi Linus,
> >
> > It doesn't change the interface or break anything; it just reserves a
> > bit so that out-of-tree patches don't collide with future
> > allocations. There are significant usages of this bit within Google
> > and Tao Bao. It is true that there has been significant pushback
> > about adding this functionality on linux-fsdevel;
>
> It's not the fact that you want to reserve a bit that is at issue
> here - it's the way it's been pushed into the tree that is the
> front-and-center issue.
>
> > I find it personally frustrating that
> > in effect, if enough people scream, they can veto an optional feature
> > that might only be implemented by a single file system.
>
> Having a significant portion of the wider fs development community
> disagree with your patches is no reason for subverting the review
> process. Besides, that's irrelevant to the issue being discussed,
> unless you are describing your motives in an effort to justify your
> actions.
>
> In fact, it's even more disturbing if this was your real motive.
> That is, is sounds somewhat like you've just admitted that you
> pushed this change silently through the ext4 tree to avoid review
> and discussion and that you are blaming the rest of the FS community
> for forcing you to take such actions.
>
> > It's not like there is any shortage of flag bits, so what's the harm
> > of reserving the bit?
>
> The harm has already been done - to the trust we've placed in you as
> a maintainer. To argue that the code does no harm is to completely
> miss the crux of the issue at hand: principles, process and trust
> are far more important in our community than a single line of
> code.
>
> Ted, it comes down to trust. If we can't trust you not to push your
> own changes to syscall APIs into the mainline tree via backdoor
> channels, then how can we trust you not to push the entire
> out-of-tree patch into the kernel the same way?

Ping.

Linus, while I am interested in an answer I think that Dave and Christoph
as Linux filesystem developers actually deserve one (instead of silently
being ignored which is also a decision in this matter).

I did not see an answer in linux-2.6 commit log as of today so far.

Thanks,
--
Martin 'Helios' Steigerwald - http://www.Lichtvoll.de
GPG: 03B0 0D6C 0040 0710 4AFA B82F 991B EAAC A599 84C7


\
 
 \ /
  Last update: 2012-12-05 12:21    [W:0.126 / U:16.104 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site