Messages in this thread | | | From | Grant Likely <> | Subject | Re: [PATCH -next] TTY: hvsi: use for_each_compatible_node() macro | Date | Wed, 05 Dec 2012 23:36:58 +0000 |
| |
On Tue, 4 Dec 2012 00:16:18 -0500, Wei Yongjun <weiyj.lk@gmail.com> wrote: > From: Wei Yongjun <yongjun_wei@trendmicro.com.cn> > > Use for_each_compatible_node() macro instead of open coding it. > > Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Acked-by: Grant Likely <grant.likely@secretlab.ca>
> --- > drivers/tty/hvc/hvsi.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/tty/hvc/hvsi.c b/drivers/tty/hvc/hvsi.c > index 5b95b4f..70e0ef7 100644 > --- a/drivers/tty/hvc/hvsi.c > +++ b/drivers/tty/hvc/hvsi.c > @@ -1187,9 +1187,7 @@ static int __init hvsi_console_init(void) > hvsi_wait = poll_for_state; /* no irqs yet; must poll */ > > /* search device tree for vty nodes */ > - for (vty = of_find_compatible_node(NULL, "serial", "hvterm-protocol"); > - vty != NULL; > - vty = of_find_compatible_node(vty, "serial", "hvterm-protocol")) { > + for_each_compatible_node(vty, "serial", "hvterm-protocol") { > struct hvsi_struct *hp; > const uint32_t *vtermno, *irq; > > >
-- Grant Likely, B.Sc, P.Eng. Secret Lab Technologies, Ltd.
| |