Messages in this thread | | | Date | Tue, 4 Dec 2012 20:30:30 +0530 | From | Santosh Shilimkar <> | Subject | Re: [linux-keystone] [PATCH v2] drivers: cma: fix addressing on PAE machines |
| |
On Tuesday 04 December 2012 06:37 PM, Michal Nazarewicz wrote: >> On Monday 03 December 2012 09:16 PM, Vitaly Andrianov wrote: >>> This patch fixes a couple of bugs that otherwise impair CMA functionality on >>> PAE machines: >>> >>> - alignment must be a 64-bit type when running on systems with 64-bit >>> physical addresses. If this is not the case, the limit calculation thunks >>> allocations down to an address range < 4G. >>> >>> - The allocated range check is removed. On 32bit ARM kernel with LPAE >>> enabled the base may be allocated outside the fist 4GB of physical >>> memory (keystone SoC for example). > > On Tue, Dec 04 2012, Santosh Shilimkar wrote: >> Any reason you have clubbed two fixes in one patch. Its better to keep >> the two fixes separate patches. > > They are all related to the very same issue, and what the whole patch > does is change the type used to store physical addresses from unsigned > long to phys_addr_t. This is really a single change. > Thanks for clarification. 64 bit alignment fix and the allocation range checks can be two separate fixes and that is exactly what change log describes. You have a last say though :-) No problem if you want to commit the patch as is.
Regards Santosh
| |