Messages in this thread | | | Date | Mon, 31 Dec 2012 14:05:34 +0530 | From | Ananth N Mavinakayanahalli <> | Subject | Re: [PATCH 2/2] uprobes: Change handle_swbp() to expose bp_vaddr to handler_chain() |
| |
On Sun, Dec 30, 2012 at 04:47:22PM +0100, Oleg Nesterov wrote: > Change handle_swbp() to set regs->ip = bp_vaddr in advance, this is > what consumer->handler() needs but uprobe_get_swbp_addr() is not > exported. > > This also simplifies the code and makes it more consistent across > the supported architectures. handle_swbp() becomes the only caller > of uprobe_get_swbp_addr().
The arch agnostic bits look fine to me.
> Signed-off-by: Oleg Nesterov <oleg@redhat.com> Acked-by: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
| |