Messages in this thread | | | Date | Mon, 03 Dec 2012 17:39:39 +0100 | From | Michal Marek <> | Subject | Re: [PATCH 2/2] scripts/tags.sh: Support compiled source |
| |
On 3.12.2012 17:22, Joonsoo Kim wrote: > We usually have interst in compiled files only, > because they are strongly related to individual's work. > Current tags.sh can't select compiled files, so support it. > > We can use this functionality like below. > "make cscope O=. SRCARCH=xxxx SUBARCH=compiled"
I like the idea, but please try to come up with a different syntax that does not abuse SUBARCH.
> +all_compiled_sources() > +{ > + for i in $(all_sources); do > + if [[ $i =~ .*c$ || $i =~ .*S$ ]]; then > + j=${i/\.[cS]/\.o}
Please use 'case "$i" in ...' instead of the bash-specific [[ ... ]] construct.
Michal
| |