lkml.org 
[lkml]   [2012]   [Dec]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[ 44/89] xhci: Remove scary warnings about transfer issues.
    3.2-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Sarah Sharp <sarah.a.sharp@linux.intel.com>

    commit 2a9227a5eeaeb3f91e3a72ceea4fa59016ca5d20 upstream.

    Getting a short packet or a babble error is usually a recoverable error,
    so stop scaring users with warnings in dmesg when xHCI debugging is turned
    off.

    Signed-off-by: Sarah Sharp <sarah.a.sharp@linux.intel.com>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/usb/host/xhci-ring.c | 7 +++----
    1 file changed, 3 insertions(+), 4 deletions(-)

    diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c
    index d030f0b..560b7d7 100644
    --- a/drivers/usb/host/xhci-ring.c
    +++ b/drivers/usb/host/xhci-ring.c
    @@ -1643,7 +1643,6 @@ static int process_ctrl_td(struct xhci_hcd *xhci, struct xhci_td *td,
    }
    break;
    case COMP_SHORT_TX:
    - xhci_warn(xhci, "WARN: short transfer on control ep\n");
    if (td->urb->transfer_flags & URB_SHORT_NOT_OK)
    *status = -EREMOTEIO;
    else
    @@ -1985,7 +1984,7 @@ static int handle_tx_event(struct xhci_hcd *xhci,
    xhci_dbg(xhci, "Stopped on No-op or Link TRB\n");
    break;
    case COMP_STALL:
    - xhci_warn(xhci, "WARN: Stalled endpoint\n");
    + xhci_dbg(xhci, "Stalled endpoint\n");
    ep->ep_state |= EP_HALTED;
    status = -EPIPE;
    break;
    @@ -1995,11 +1994,11 @@ static int handle_tx_event(struct xhci_hcd *xhci,
    break;
    case COMP_SPLIT_ERR:
    case COMP_TX_ERR:
    - xhci_warn(xhci, "WARN: transfer error on endpoint\n");
    + xhci_dbg(xhci, "Transfer error on endpoint\n");
    status = -EPROTO;
    break;
    case COMP_BABBLE:
    - xhci_warn(xhci, "WARN: babble error on endpoint\n");
    + xhci_dbg(xhci, "Babble error on endpoint\n");
    status = -EOVERFLOW;
    break;
    case COMP_DB_ERR:



    \
     
     \ /
      Last update: 2012-12-03 16:21    [W:4.027 / U:0.480 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site