lkml.org 
[lkml]   [2012]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[ 082/173] iscsit: use GFP_ATOMIC under spin lock
    3.2-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>

    commit 3c989d7603872bf878840f7ce3ea49b73bea4c6c upstream.

    The function iscsit_build_conn_drop_async_message() is called
    from iscsit_close_connection() with spin lock 'sess->conn_lock'
    held, so we should use GFP_ATOMIC instead of GFP_KERNEL.

    Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
    Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/target/iscsi/iscsi_target.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/target/iscsi/iscsi_target.c b/drivers/target/iscsi/iscsi_target.c
    index 4ad14ac..339f97f 100644
    --- a/drivers/target/iscsi/iscsi_target.c
    +++ b/drivers/target/iscsi/iscsi_target.c
    @@ -2336,7 +2336,7 @@ static void iscsit_build_conn_drop_async_message(struct iscsi_conn *conn)
    if (!conn_p)
    return;

    - cmd = iscsit_allocate_cmd(conn_p, GFP_KERNEL);
    + cmd = iscsit_allocate_cmd(conn_p, GFP_ATOMIC);
    if (!cmd) {
    iscsit_dec_conn_usage_count(conn_p);
    return;



    \
     
     \ /
      Last update: 2012-12-29 00:21    [W:4.149 / U:0.148 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site