Messages in this thread Patch in this message | | | From | Sasha Levin <> | Subject | [PATCH] module: prevent warning when finit_module a 0 sized file | Date | Fri, 28 Dec 2012 14:27:17 -0500 |
| |
If we try to finit_module on a file sized 0 bytes vmalloc will scream and spit out a warning.
Since modules have to be bigger than 0 bytes anyways we can just check that beforehand and avoid the warning.
Signed-off-by: Sasha Levin <sasha.levin@oracle.com> --- kernel/module.c | 6 ++++++ 1 file changed, 6 insertions(+)
diff --git a/kernel/module.c b/kernel/module.c index 250092c..2e1ce2e 100644 --- a/kernel/module.c +++ b/kernel/module.c @@ -2527,6 +2527,12 @@ static int copy_module_from_fd(int fd, struct load_info *info) err = -EFBIG; goto out; } + + if (stat.size == 0) { + err = -EINVAL; + goto out; + } + info->hdr = vmalloc(stat.size); if (!info->hdr) { err = -ENOMEM; -- 1.8.0.2
| |