Messages in this thread | | | Date | Thu, 27 Dec 2012 16:57:17 -0800 | Subject | Re: [PATCH] x86, realmode: set real_mode permissions early | From | Yinghai Lu <> |
| |
On Thu, Dec 27, 2012 at 4:01 PM, H. Peter Anvin <hpa@zytor.com> wrote: > On 12/27/2012 03:56 PM, Yinghai Lu wrote: >>> >>> >>> I'm looking at this patch in the -v8 branch: you need to update the >>> comment above that function to say that trampoline code needs to be >>> marked X now earlier. >> >> >> Not sure if we really need to add such comment in the code. >> >> Peter, what is your idea about this? >> > > It would be good to note why the early_initcall is the right phase. >
How about:
--- Trampoline will be executed by APs with SMP, So we need to set it EXEC in do_pre_smp_initcalls and it is early_initcall. ---
| |