Messages in this thread | | | Date | Fri, 21 Dec 2012 13:36:10 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH v2] mm,ksm: use new hashtable implementation |
| |
On Fri, 21 Dec 2012 12:46:50 -0500 Sasha Levin <sasha.levin@oracle.com> wrote:
> Switch ksm to use the new hashtable implementation. This reduces the amount of > generic unrelated code in the ksm module.
hm, include/linux/hashtable.h:hash_min() is rather dangerous - it returns different values depending on the size of the first argument. So if the calling code mixes up its ints and longs (and boy we do that a lot), the result will work on 32-bit and fail on 64-bit.
Also, is there ever likely to be a situation where the first arg to hash_min() is *not* a pointer? Perhaps it would be better to concede to reality: rename `key' to `ptr' and remove all those typcasts you just added.
| |