lkml.org 
[lkml]   [2012]   [Dec]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] epoll: stop comparing pointers with 0 in self-test app
I don't see anything obviously wrong here...
Reviewed-By: Daniel Hazelton <dshadowwolf@gmail.com>

On 12/20/2012 02:11 PM, Sasha Levin wrote:
> Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
> ---
> tools/testing/selftests/epoll/test_epoll.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/epoll/test_epoll.c b/tools/testing/selftests/epoll/test_epoll.c
> index 4a14a7f..1034ed4 100644
> --- a/tools/testing/selftests/epoll/test_epoll.c
> +++ b/tools/testing/selftests/epoll/test_epoll.c
> @@ -199,8 +199,8 @@ int main(int argc, char **argv)
>
> epoll_items = malloc(n_epoll_items * sizeof(struct epoll_item_private));
>
> - if (epoll_set < 0 || epoll_items == 0 || write_thread_data.fds == 0 ||
> - read_thread_data == 0 || read_threads == 0)
> + if (epoll_set < 0 || !epoll_items || write_thread_data.fds == NULL ||
> + !read_thread_data || !read_threads)
> goto error;
>
> if (sysconf(_SC_NPROCESSORS_ONLN) < 2) {
>



\
 
 \ /
  Last update: 2012-12-21 04:41    [W:0.280 / U:3.580 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site