lkml.org 
[lkml]   [2012]   [Dec]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC Patch v1 45/55] ARC: unaligned access emulation
On Monday 12 November 2012 07:30 PM, Arnd Bergmann wrote:
> On Monday 12 November 2012, Vineet.Gupta1@synopsys.com wrote:
>> +
>> +config ARC_MISALIGN_ACCESS
>> + bool "Emulate unaligned memory access (userspace only)"
>> + default N
>> + help
>> + This enables misaligned 16 & 32 bit memory access from user space.
>> + Use ONLY-IF-ABS-NECESSARY as it will be very slow and also can hide
>> + potential bugs in code
>
> parisc and ia64 both have the same feature, and they use sysctl to configure
> it at run-time. Maybe you should pick one of the two sysctl implementations
> and hook that up to your implementation as well.

Sounds like a good idea.

Looking at your suggestion, the sysctl interface in both of those is for
slightly different semantics and ARC would possibly need a bit from
both. So to avoid duplication, I'm proposing following changes to
kernel/sysctl.c and the generic options selected by respective arches.

* no_unaligned_warning:CONFIG_IA64 => CONFIG_SYSCTL_ARCH_UNALIGN_NO_WARN
*unaligned_enabled: __hppa__ => CONFIG_SYSCTL_ARCH_UNALIGN_ALLOW

If you can think of better(smaller) names, please do let me know :-)

If we agree in principle, I'll cookup the patches and seek the ACKs from
ARCH maintainers (assuming my CC list above is right). And to keep
things simple, we can route the kernel/sysctl.c changes via the ARC
submission tree.

Thx,
Vineet



\
 
 \ /
  Last update: 2012-12-20 08:41    [W:0.094 / U:20.692 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site