[lkml]   [2012]   [Dec]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] mm/sparse: don't check return value of alloc_bootmem calls
On Thu, 20 Dec 2012, Sasha Levin wrote:

> So what we really need is to update the documentation of __alloc_bootmem_node, I'll send
> a patch that does that instead.

It panics iff slab is not available to allocate from yet, otherwise it's
just a wrapper around kmalloc(). This emits a warning to the kernel log,
though, so __alloc_bootmem_node() should certainly not be called that late
in the boot sequence.

Since __alloc_bootmem_node_nopanic() is the way to avoid the panic, I
think the change that should be made here so to panic even when the
kmalloc() fails in __alloc_bootmem_node(), __alloc_bootmem_node_high(),
and __alloc_bootmem_low_node().

 \ /
  Last update: 2012-12-20 22:21    [W:0.159 / U:1.368 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site