lkml.org 
[lkml]   [2012]   [Dec]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] cgroup: remove redundant check
On Thu, Dec 20, 2012 at 02:11:31PM -0500, Sasha Levin wrote:
> We already know that 'event' is non-NULL, remove the redundant check.
>
> Signed-off-by: Sasha Levin <sasha.levin@oracle.com>

I don't know. I kinda like that test there. It's not an error path
and tearing down everything which could have been allocated. If the
test not being used is bothering, convert return -ENOMEM to goto fail?

--
tejun


\
 
 \ /
  Last update: 2012-12-20 21:41    [W:0.164 / U:3.476 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site