Messages in this thread |  | | Date | Thu, 20 Dec 2012 14:24:34 -0500 | From | Sasha Levin <> | Subject | Re: [PATCH] cgroup: remove redundant check |
| |
On 12/20/2012 02:18 PM, Tejun Heo wrote: > On Thu, Dec 20, 2012 at 02:11:31PM -0500, Sasha Levin wrote: >> We already know that 'event' is non-NULL, remove the redundant check. >> >> Signed-off-by: Sasha Levin <sasha.levin@oracle.com> > > I don't know. I kinda like that test there. It's not an error path > and tearing down everything which could have been allocated. If the > test not being used is bothering, convert return -ENOMEM to goto fail?
Can't say it's bothering. If you'd prefer to leave it as is I'm okay with doing that.
Thanks, Sasha
|  |