Messages in this thread | | | Subject | Re: [PATCH 2/2] MCE, AMD: MCE decoding support for AMD Family 16h | From | Joe Perches <> | Date | Tue, 18 Dec 2012 14:10:59 -0800 |
| |
On Tue, 2012-12-18 at 15:06 -0600, Jacob Shin wrote: > Add MCE decoding logic for AMD Family 16h processors.
More trivia:
> diff --git a/drivers/edac/mce_amd.c b/drivers/edac/mce_amd.c [] > @@ -64,6 +64,10 @@ EXPORT_SYMBOL_GPL(to_msgs); > const char * const ii_msgs[] = { "MEM", "RESV", "IO", "GEN" }; > EXPORT_SYMBOL_GPL(ii_msgs); > > +/* internal error type */ > +const char * const uu_msgs[] = { "RESV", "RESV", "HWA", "RESV" }; > +EXPORT_SYMBOL_GPL(uu_msgs);
Do these really need to be exported? These don't seem to be used outside of mce_amd.
If these really need export, are these very good names? Perhaps these should be prefixed with something?
| |