Messages in this thread | | | Date | Mon, 17 Dec 2012 20:37:08 -0500 | From | Jason Cooper <> | Subject | Re: [PATCH 3/3] ARM: Dove: add Cubox sdhci card detect gpio |
| |
On Tue, Dec 18, 2012 at 01:50:12AM +0100, Sebastian Hesselbarth wrote: > On 12/18/2012 01:38 AM, Jason Cooper wrote: > > On Tue, Dec 18, 2012 at 01:24:29AM +0100, Sebastian Hesselbarth wrote: > >> Card detect for sdhci on Cubox is connected to the wrong pin > >> (sdio1_cd instead of sdio0_cd). With support for cd-gpios and > >> pinctrl add the corresponding properties to DT for Cubox. > >> > >> Signed-off-by: Sebastian Hesselbarth<sebastian.hesselbarth@gmail.com> > >> ... > >> +&sdio0 { > >> + status = "okay"; > >> + /* sdio0 card detect is connected to wrong pin on CuBox */ > >> + cd-gpios =<&gpio0 12 1>; > > > > this looks like a fix that should be merged into v3.8, I'll cue it up > > for v3.8-rc2. > > Jason, > > it is more a feature than a fix, as gpio-cd support for sdhci-dove > moved in lately. You want me to split this patch from the other two > (that I'll reorder as requested)?
I was referring to the code more than the physical feature itself. You appear to remove the default &sdio0, and replace it with a working version. Looked like a fix to me ;-)
No need to send it separate, I'll apply it as is once v3.8-rc1 drops.
thx,
Jason.
| |