lkml.org 
[lkml]   [2012]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [tip:x86/microcode] x86/microcode_intel_early.c: Early update ucode on Intel's CPU
    From
    On Mon, Dec 17, 2012 at 3:11 PM, H. Peter Anvin <hpa@zytor.com> wrote:
    > On 12/17/2012 02:47 PM, Yinghai Lu wrote:
    >>
    >>
    >> Peter, can you check that branch again?
    >>
    >> I moved the early_trap_init after init_mem_mapping.
    >> so for 64bit native, init_mem_mapping will setup page table for ram from
    >> blank.
    >>
    >
    > Looks better, at first glance at least. There are a couple of unnecessary
    > changes (the counter in head_64.S cannot exceed 32 bits once computed, so
    > the change from %rcx to %ecx change is pointless.)

    ok, return to use %ecx

    >
    > There is another bug in my patch: it either needs to mask off the NX bit if
    > we are running on non-NX-enabled hardware, or it needs to not set the NX bit
    > (which is mostly okay that early on, I suspect.)

    i test that in kvm guest, and westmere, current version seem ok.

    will repost the patchset to list to get more review.

    :


    \
     
     \ /
      Last update: 2012-12-18 01:01    [W:2.401 / U:0.084 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site