lkml.org 
[lkml]   [2012]   [Dec]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 1/2] bcma: BCMA_DRIVER_GPIO should depend on GPIOLIB instead of selecting it
    Date
    Commit cf0936b06d8e98a157630e99f647e2ff6d29d7ad ("bcma: add GPIO driver")
    added BCMA_DRIVER_GPIO, which unconditionally selects GPIOLIB, causing
    a Kconfig warning:

    warning: (ARCH_REQUIRE_GPIOLIB && SSB_DRIVER_GPIO && BCMA_DRIVER_GPIO && MFD_TC6393XB && FB_VIA) selects GPIOLIB which has unmet direct dependencies (ARCH_WANT_OPTIONAL_GPIOLIB || ARCH_REQUIRE_GPIOLIB)

    and build failure for m68k/allmodconfig:

    In file included from include/linux/bcma/bcma.h:8,
    from drivers/bcma/bcma_private.h:9,
    from drivers/bcma/main.c:9:
    include/linux/bcma/bcma_driver_chipcommon.h:582: error: field ‘gpio’ has incomplete type
    In file included from include/linux/bcma/bcma.h:12,
    from drivers/bcma/bcma_private.h:9,
    from drivers/bcma/main.c:9:
    include/linux/ssb/ssb.h:440: error: field ‘gpio’ has incomplete type
    make[4]: *** [drivers/bcma/main.o] Error 1
    make[3]: *** [drivers/bcma/] Error 2

    Turn the select into a dependency to fix this.

    Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
    ---
    drivers/bcma/Kconfig | 3 +--
    1 files changed, 1 insertions(+), 2 deletions(-)

    diff --git a/drivers/bcma/Kconfig b/drivers/bcma/Kconfig
    index d7b56a8..8b4221c 100644
    --- a/drivers/bcma/Kconfig
    +++ b/drivers/bcma/Kconfig
    @@ -67,8 +67,7 @@ config BCMA_DRIVER_GMAC_CMN

    config BCMA_DRIVER_GPIO
    bool "BCMA GPIO driver"
    - depends on BCMA
    - select GPIOLIB
    + depends on BCMA && GPIOLIB
    help
    Driver to provide access to the GPIO pins of the bcma bus.

    --
    1.7.0.4
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-12-16 17:01    [W:0.022 / U:0.332 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site