lkml.org 
[lkml]   [2012]   [Dec]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 04/10] x86/microcode_core_early.c: Define interfaces for early loading ucode
On Sun, Dec 16, 2012 at 06:09:12PM +0000, Yu, Fenghua wrote:
> Nothing wrong with taking the parameters. But CPUID_IS is only limited
> in this file. There is no other places to use it. I think either way
> is ok.

Please don't do this. Anything can happen, someone can copy it somewhere
else and try to use it, unification, code movement can all of a sudden
break things in the most mysterious ways.

However, if you make the macro definition self-contained. none of those
issues will happen.

Thanks.

--
Regards/Gruss,
Boris.

Sent from a fat crate under my desk. Formatting is fine.
--


\
 
 \ /
  Last update: 2012-12-16 19:41    [W:2.055 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site