lkml.org 
[lkml]   [2012]   [Dec]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH] vfs: update atimes over one day in the past or future

From 3d56c131b58a21c05bcd677b9d2ba915abcbf195 Mon Sep 17 00:00:00 2001
From: yangsheng <sickamd@gmail.com>
Date: Sat, 15 Dec 2012 21:46:22 +0800
Subject: [PATCH] vfs: update atimes over one day in the past or future

Relatime should update the inode atime if it is more than one day
in the future. The original problem seen was a tarball that had
a bad atime in the distant future, but could also happen if someone
fat-fingers a "touch". The future atime will never be fixed.

Without relatime enabled, a future atime is updated to the current
kernel time on access. Relatime is meant to reduce the frequency
of atime updates, not decide if whether the system clock or the
inode timestamp is correct or not.

Signed-off-by: Yang Sheng <sickamd@gmail.com>
Signed-off-by: Andreas Dilger <adilger@dilger.ca>
Acked-by: David Chinner <david@fromorbit.com>
CC: stable@vger.kernel.org
---
fs/inode.c | 7 ++++---
1 个文件被修改,插入 4 行(+),删除 3 行(-)

diff --git a/fs/inode.c b/fs/inode.c
index 14084b7..8713dc8 100644
--- a/fs/inode.c
+++ b/fs/inode.c
@@ -1488,10 +1488,11 @@ static int relatime_need_update(struct vfsmount *mnt, struct inode *inode,
return 1;

/*
- * Is the previous atime value older than a day? If yes,
- * update atime:
+ * Update atime if it's older than a day or more than a day
+ * in the future, which we assume is corrupt.
+ *
*/
- if ((long)(now.tv_sec - inode->i_atime.tv_sec) >= 24*60*60)
+ if (abs(now.tv_sec - inode->i_atime.tv_sec) >= 24*60*60)
return 1;
/*
* Good, we can skip the atime update:
--
1.7.11.7
\
 
 \ /
  Last update: 2012-12-15 17:01    [W:0.057 / U:7.356 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site