Messages in this thread | | | Date | Fri, 14 Dec 2012 23:22:10 -0800 | Subject | Re: [PATCH] time: create __getnstimeofday for WARNless calls | From | Kees Cook <> |
| |
On Fri, Dec 14, 2012 at 5:16 PM, John Stultz <johnstul@us.ibm.com> wrote: > On 12/13/2012 10:17 AM, Kees Cook wrote: >> >> John, any feedback on this? >> > Sorry, yea, I've been meaning to get back to this. > > I'm still on the fence about just making getnstimeofday() safe for when > timekeeping is suspended, but at the same time, your issue needs fixing. > Also bailing out at the end still seems off to me. Even if someone is using > the values despite the WARN_ON, they really are getting junk values, and for > all the time that WARN_ON has been there, you're the first to report running > into it. > > Even so, I think I'm ok with this patch for now, but I suspect we may want > to rework it later. > > Looking at my inbox, I actually can't find a copy of this specific patch. Do > you mind bouncing it to me, so I have something I can apply? > > Should this also get marked for -stable?
Nah, I don't think it's worth it.
Thanks!
-Kees
-- Kees Cook Chrome OS Security
| |