Messages in this thread | | | Subject | Re: [patch 2/8] mm: vmscan: disregard swappiness shortly before going OOM | From | Simon Jeons <> | Date | Wed, 12 Dec 2012 23:56:30 -0600 |
| |
On Wed, 2012-12-12 at 16:43 -0500, Johannes Weiner wrote: > When a reclaim scanner is doing its final scan before giving up and > there is swap space available, pay no attention to swappiness > preference anymore. Just swap. >
Confuse! If it's final scan and still swap space available, why nr[lru] = div64_u64(scan * fraction[file], denominator); instead of nr[lru] = scan; ?
> Note that this change won't make too big of a difference for general > reclaim: anonymous pages are already force-scanned when there is only > very little file cache left, and there very likely isn't when the > reclaimer enters this final cycle. > > Signed-off-by: Johannes Weiner <hannes@cmpxchg.org> > --- > mm/vmscan.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index 3874dcb..6e53446 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -1751,7 +1751,7 @@ static void get_scan_count(struct lruvec *lruvec, struct scan_control *sc, > unsigned long scan; > > scan = get_lru_size(lruvec, lru); > - if (sc->priority || noswap || !vmscan_swappiness(sc)) { > + if (sc->priority || noswap) { > scan >>= sc->priority; > if (!scan && force_scan) > scan = SWAP_CLUSTER_MAX;
| |