Messages in this thread | | | Date | Wed, 12 Dec 2012 11:14:50 +0100 | From | Alexander Holler <> | Subject | Re: [PATCH 4/4 v3] rtc: add rtc-driver for HID sensors of type time |
| |
Am 12.12.2012 10:51, schrieb Lars-Peter Clausen:
> Looks good, but as I wrote during the last review the __devinits need to go. > A few other suggerstions online
Oh, have forgotten it. Ok, will make a v4, changing the other few things too.
>> + case HID_USAGE_SENSOR_TIME_MONTH: >> + time_buf->tm_mon = --*(u8 *)raw_data;
Time sensors are sending the month in the range 1-12, not 0-11.
Regards,
Alexander
| |