Messages in this thread | | | Date | Wed, 12 Dec 2012 08:28:36 +0530 | Subject | Re: [RFC PATCH 2/3] regulator: max77686: Add support for various operating modes | From | Abhilash Kesavan <> |
| |
On Tue, Dec 11, 2012 at 6:27 PM, Mark Brown <broonie@opensource.wolfsonmicro.com> wrote: > On Mon, Dec 10, 2012 at 02:06:49PM +0530, Abhilash Kesavan wrote: >> On Mon, Dec 10, 2012 at 1:49 PM, Abhilash Kesavan >> <kesavan.abhilash@gmail.com> wrote: > >> > Mark Brown <broonie <at> opensource.wolfsonmicro.com> writes: > >> >> Binding documenation is mandatory for any new OF properties, please add >> >> this. > >> > Patch 3/3 of this series adds documentation for the max77686-opmode property. > > There is no point in splitting changes like this up, it just makes > review harder - in this case it caused me to not read your patch due > to the missing documentation. Put the whole change together unless > things are getting too big to review. OK.
Can you please have a look at Doug's proposal for handling the operating mode generically in patch 3/3 of this series. If you are OK with it then I'll start work on implementing it.
Thanks, Abhilash
| |