lkml.org 
[lkml]   [2012]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH 00/49] Automatic NUMA Balancing v10

* Ingo Molnar <mingo@kernel.org> wrote:

> > reasons. As it turns out, a printk() bodge showed that
> > nr_cpus_allowed == 80 set in sched_init_smp() while
> > num_online_cpus() == 48. This effectively disabling
> > numacore. If you had responded to the bug report, this would
> > likely have been found last Wednesday.
>
> Does changing it from num_online_cpus() to num_possible_cpus()
> help? (Can send a patch if you want.)

I.e. something like the patch below.

Thanks,

Ingo

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 503ec29..9d11a8a 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -2646,7 +2646,7 @@ static bool task_numa_candidate(struct task_struct *p)

/* Don't disturb hard-bound tasks: */
if (sched_feat(NUMA_EXCLUDE_AFFINE)) {
- if (p->nr_cpus_allowed != num_online_cpus())
+ if (p->nr_cpus_allowed != num_possible_cpus())
return false;
}


\
 
 \ /
  Last update: 2012-12-10 13:41    [W:0.121 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site