lkml.org 
[lkml]   [2012]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/7] uprobes: Move __set_bit(UPROBE_SKIP_SSTEP) into alloc_uprobe()


> Cosmetic. __set_bit(UPROBE_SKIP_SSTEP) is the part of initialization,
> it is not clear why it is set in insert_uprobe().
>
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>

> ---
> kernel/events/uprobes.c | 5 ++---
> 1 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c
> index 5e22faf..e9f22ed 100644
> --- a/kernel/events/uprobes.c
> +++ b/kernel/events/uprobes.c
> @@ -430,9 +430,6 @@ static struct uprobe *insert_uprobe(struct uprobe *uprobe)
> u = __insert_uprobe(uprobe);
> spin_unlock(&uprobes_treelock);
>
> - /* For now assume that the instruction need not be single-stepped */
> - __set_bit(UPROBE_SKIP_SSTEP, &uprobe->flags);
> -
> return u;
> }
>
> @@ -454,6 +451,8 @@ static struct uprobe *alloc_uprobe(struct inode *inode, loff_t offset)
> uprobe->offset = offset;
> init_rwsem(&uprobe->consumer_rwsem);
> mutex_init(&uprobe->copy_mutex);
> + /* For now assume that the instruction need not be single-stepped */
> + __set_bit(UPROBE_SKIP_SSTEP, &uprobe->flags);
>
> /* add to uprobes_tree, sorted on inode:offset */
> cur_uprobe = insert_uprobe(uprobe);
> --
> 1.5.5.1
>



\
 
 \ /
  Last update: 2012-12-10 07:41    [W:1.075 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site