Messages in this thread | | | Date | Mon, 10 Dec 2012 14:32:06 +0530 | From | Vaibhav Hiremath <> | Subject | Re: [PATCH] da8xx: Allow use by am33xx based devices |
| |
On 12/6/2012 1:38 PM, Manjunathappa, Prakash wrote: > Hi Tomi, > > On Wed, Oct 31, 2012 at 10:52:59, Manjunathappa, Prakash wrote: >> Hi, >> >> On Wed, Oct 31, 2012 at 21:26:08, Pantelis Antoniou wrote: >>> This driver can be used for AM33xx devices, like the popular beaglebone. >>> >>> Signed-off-by: Pantelis Antoniou <panto@antoniou-consulting.com> >>> --- >>> drivers/video/Kconfig | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig >>> index 9791d10..e7868d8 100644 >>> --- a/drivers/video/Kconfig >>> +++ b/drivers/video/Kconfig >>> @@ -2202,7 +2202,7 @@ config FB_SH7760 >>> >>> config FB_DA8XX >>> tristate "DA8xx/OMAP-L1xx Framebuffer support" >>> - depends on FB && ARCH_DAVINCI_DA8XX >>> + depends on FB && (ARCH_DAVINCI_DA8XX || SOC_AM33XX) >> >> Agreed this is present on da8xx and am33xx, but moving forward for >> supporting DT, we should be avoiding these dependencies. So instead >> change this to remove machine dependencies. >> > > I could be wrong here, having dependency on platform seems to be right. > Otherwise may lead to build errors for other platforms.
No, it should not result in to build error unless driver uses some platform specific api's.
Thanks, Vaibhav
> Please ignore my > comments and accept this patch. > > Thanks, > Prakash > _______________________________________________ > Davinci-linux-open-source mailing list > Davinci-linux-open-source@linux.davincidsp.com > http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source >
| |