Messages in this thread | | | From | saeed bishara <> | Date | Mon, 10 Dec 2012 12:04:15 +0200 | Subject | Re: [PATCH v4 1/5] net: Add support for hardware-offloaded encapsulation |
| |
> +static inline struct iphdr *inner_ip_hdr(const struct sk_buff *skb) > +{ > + return (struct iphdr *)skb_inner_network_header(skb); > +}
Hi, I'm a little bit bothered because of those inner_ functions, what about the following approach: 1. the skb will have a new state, that state can be outer (normal mode) and inner. 2. when you change the state to inner, all the helper functions such as ip_hdr will return the innter header.
that's ofcourse the API side. the implementation may still use the fields you added to the skb.
what you think? saeed
| |