Messages in this thread | | | Date | Thu, 08 Nov 2012 17:22:35 +0800 | From | Wen Congyang <> | Subject | Re: [PATCH v2] memory-hotplug: fix NR_FREE_PAGES mismatch's fix |
| |
At 11/08/2012 05:06 PM, Wen Congyang Wrote: > > When a page is freed and put into pcp list, get_freepage_migratetype() > doesn't return MIGRATE_ISOLATE even if this pageblock is isolated. > So we should use get_freepage_migratetype() instead of mt to check > whether it is isolated.
In my local tree, there are some patches from isimatu, so I don't add -s option when generating the patch. So I forgot to add:
Signed-off-by: Wen Congyang <wency@cn.fujitsu.com> Reported-by: Jianguo Wu <wujianguo106@gmail.com>
> --- > mm/page_alloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 027afd0..795875f 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -667,7 +667,7 @@ static void free_pcppages_bulk(struct zone *zone, int count, > /* MIGRATE_MOVABLE list may include MIGRATE_RESERVEs */ > __free_one_page(page, zone, 0, mt); > trace_mm_page_pcpu_drain(page, 0, mt); > - if (likely(mt != MIGRATE_ISOLATE)) { > + if (likely(get_pageblock_migratetype(page) != MIGRATE_ISOLATE)) { > __mod_zone_page_state(zone, NR_FREE_PAGES, 1); > if (is_migrate_cma(mt)) > __mod_zone_page_state(zone, NR_FREE_CMA_PAGES, 1);
| |