lkml.org 
[lkml]   [2012]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 00/13] A simple hardware detector for latency as well as throughtput ver 0.10
On Sun, Nov 04, 2012 at 08:59:31PM -0500, Luming Yu wrote:
> Back to July of this year, I sent the first round of the tool.
> Now I've polished it a little bit.
>
> The patch is the fist step to test some basic hardware functions like
> TSC to help people understand if there is any hardware latency as well
> as throughput problem exposed on bare metal or left behind by BIOS or
> interfered by SMI. Currently the patch tests TSC, CPU Frequency, and
> RDRAND, which is a new CPU instruction to get random number introudced
> in new CPU like Intel Ivy Bridge, in stop_machine context.

You are adding a new file, drivers/misc/hw_latency_test.c to the
kernel. I don't think it makes sense to include the file, and then
follow it with 12 patches which modify the file. You don't need to
"show your work" with the various bug fixes that has been made since
July. I'd recommend collapsing all of the collected patches plus the
base file into a single commit.

Regards,

- Ted


\
 
 \ /
  Last update: 2012-11-09 00:01    [W:0.122 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site