lkml.org 
[lkml]   [2012]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/5] checkpatch: Remove reference to feature-removal-schedule.txt.
On Thu, Nov 08, 2012 at 09:50:33PM +0800, Tao Ma wrote:
> From: Tao Ma <boyu.mt@taobao.com>
>
> In 9c0ece069, Linus removed feature-removal-schedule.txt from Documentation,
> but there is still some reference to this file. So remove them.
>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Andy Whitcroft <apw@canonical.com>
> Cc: Linus Torvalds <torvalds@linux-foundation.org>
> Signed-off-by: Tao Ma <boyu.mt@taobao.com>
> ---
> scripts/checkpatch.pl | 44 --------------------------------------------
> 1 files changed, 0 insertions(+), 44 deletions(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 21a9f5d..b0240b8 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -352,27 +352,6 @@ sub deparenthesize {
>
> $chk_signoff = 0 if ($file);
>
> -my @dep_includes = ();
> -my @dep_functions = ();
> -my $removal = "Documentation/feature-removal-schedule.txt";
> -if ($tree && -f "$root/$removal") {
> - open(my $REMOVE, '<', "$root/$removal") ||
> - die "$P: $removal: open failed - $!\n";
> - while (<$REMOVE>) {
> - if (/^Check:\s+(.*\S)/) {
> - for my $entry (split(/[, ]+/, $1)) {
> - if ($entry =~ m@include/(.*)@) {
> - push(@dep_includes, $1);
> -
> - } elsif ($entry !~ m@/@) {
> - push(@dep_functions, $entry);
> - }
> - }
> - }
> - }
> - close($REMOVE);
> -}
> -
> my @rawlines = ();
> my @lines = ();
> my $vname;
> @@ -3181,29 +3160,6 @@ sub process {
> }
> }
>
> -# don't include deprecated include files (uses RAW line)
> - for my $inc (@dep_includes) {
> - if ($rawline =~ m@^.\s*\#\s*include\s*\<$inc>@) {
> - ERROR("DEPRECATED_INCLUDE",
> - "Don't use <$inc>: see Documentation/feature-removal-schedule.txt\n" . $herecurr);
> - }
> - }
> -
> -# don't use deprecated functions
> - for my $func (@dep_functions) {
> - if ($line =~ /\b$func\b/) {
> - ERROR("DEPRECATED_FUNCTION",
> - "Don't use $func(): see Documentation/feature-removal-schedule.txt\n" . $herecurr);
> - }
> - }
> -
> -# no volatiles please
> - my $asm_volatile = qr{\b(__asm__|asm)\s+(__volatile__|volatile)\b};
> - if ($line =~ /\bvolatile\b/ && $line !~ /$asm_volatile/) {
> - WARN("VOLATILE",
> - "Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt\n" . $herecurr);
> - }
> -

This last bit here looks to be an accidental extra deletiong ? I don't
think this relates to the patch at hand.

> # warn about #if 0
> if ($line =~ /^.\s*\#\s*if\s+0\b/) {
> CHK("REDUNDANT_CODE",

-apw


\
 
 \ /
  Last update: 2012-11-08 19:21    [W:0.859 / U:0.436 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site