Messages in this thread | | | From | KY Srinivasan <> | Subject | RE: [PATCH] Tools: hv: Fix for long file names from readdir | Date | Thu, 8 Nov 2012 15:51:42 +0000 |
| |
> -----Original Message----- > From: Tomas Hozza [mailto:thozza@redhat.com] > Sent: Thursday, November 08, 2012 9:53 AM > To: Olaf Hering > Cc: gregkh@linuxfoundation.org; linux-kernel@vger.kernel.org; > devel@linuxdriverproject.org; apw@canonical.com; jasowang@redhat.com; KY > Srinivasan > Subject: Re: [PATCH] Tools: hv: Fix for long file names from readdir > > > > - char dev_id[256]; > > > + char dev_id[512]; > > > > Shouldnt that be PATH_MAX or similar? > > dirent->d_name should be PATH_MAX, but it is mostly > not guaranteed. And then the dev_id is concatenated > with two strings so it can exceed 256 bytes.
PATH_MAX (currently 4096 bytes) I think should suffice.
Regards,
K. Y
| |