Messages in this thread | | | Date | Wed, 7 Nov 2012 00:06:39 +0100 | From | Jan Kara <> | Subject | Re: [PATCH 7/9] quota: Use the pre-processor to compile out quotactl_cmd_write when !CONFIG_BLOCK |
| |
On Sat 03-11-12 23:02:28, Lee Jones wrote: > quotactl_cmd_write() is only ever invoked when BLOCK is configured. When > !CONFIG_BLOCK, the build warning below is displayed. Let's fix that. > > fs/quota/quota.c:311:12: warning: ‘quotactl_cmd_write’ defined but not used [-Wunused-function] Looks good. I've added the patch to my tree.
Honza
> > Cc: Jan Kara <jack@suse.cz> > Signed-off-by: Lee Jones <lee.jones@linaro.org> > --- > fs/quota/quota.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/fs/quota/quota.c b/fs/quota/quota.c > index af1661f..c7314f1 100644 > --- a/fs/quota/quota.c > +++ b/fs/quota/quota.c > @@ -307,6 +307,8 @@ static int do_quotactl(struct super_block *sb, int type, int cmd, qid_t id, > } > } > > +#ifdef CONFIG_BLOCK > + > /* Return 1 if 'cmd' will block on frozen filesystem */ > static int quotactl_cmd_write(int cmd) > { > @@ -322,6 +324,8 @@ static int quotactl_cmd_write(int cmd) > return 1; > } > > +#endif /* CONFIG_BLOCK */ > + > /* > * look up a superblock on which quota ops will be performed > * - use the name of a block device to find the superblock thereon > -- > 1.7.9.5 > -- Jan Kara <jack@suse.cz> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |