Messages in this thread | | | Date | Tue, 6 Nov 2012 10:04:26 -0500 | From | Murali Karicheri <> | Subject | Re: [PATCH v3 03/11] clk: davinci - common clk utilities to init clk driver |
| |
On 11/06/2012 04:31 AM, Sekhar Nori wrote: > > On 11/5/2012 8:50 PM, Murali Karicheri wrote: >> On 11/03/2012 08:35 AM, Sekhar Nori wrote: >>> On 10/25/2012 9:41 PM, Murali Karicheri wrote: >>>> This is the common clk driver initialization functions for DaVinci >>>> SoCs and other SoCs that uses similar hardware architecture. >>>> clock.h also defines struct types for clock definitions in a SoC >>>> and clock data type for configuring clk-mux. The initialization >>>> functions are used by clock initialization code in a specific >>>> platform/SoC. >>>> >>>> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com> >>>> --- >>>> drivers/clk/davinci/clock.c | 112 >>>> +++++++++++++++++++++++++++++++++++++++++++ >>>> drivers/clk/davinci/clock.h | 80 +++++++++++++++++++++++++++++++ >>>> 2 files changed, 192 insertions(+) >>>> create mode 100644 drivers/clk/davinci/clock.c >>>> create mode 100644 drivers/clk/davinci/clock.h >>>> >>>> diff --git a/drivers/clk/davinci/clock.c b/drivers/clk/davinci/clock.c >>>> new file mode 100644 >>>> index 0000000..ad02149 >>>> --- /dev/null >>>> +++ b/drivers/clk/davinci/clock.c >>>> @@ -0,0 +1,112 @@ >>>> +/* >>>> + * clock.c - davinci clock initialization functions for various clocks >>>> + * >>>> + * Copyright (C) 2006-2012 Texas Instruments. >>>> + * Copyright (C) 2008-2009 Deep Root Systems, LLC >>>> + * >>>> + * This program is free software; you can redistribute it and/or modify >>>> + * it under the terms of the GNU General Public License as published by >>>> + * the Free Software Foundation; either version 2 of the License, or >>>> + * (at your option) any later version. >>>> + */ >>>> +#include <linux/init.h> >>>> +#include <linux/clk-provider.h> >>>> +#include <linux/clkdev.h> >>>> +#include <linux/io.h> >>>> +#include <linux/slab.h> >>>> + >>>> +#include "clk-pll.h" >>>> +#include "clk-psc.h" >>>> +#include "clk-div.h" >>>> +#include "clock.h" >>>> + >>>> +static DEFINE_SPINLOCK(_lock); >>>> + >>>> +#ifdef CONFIG_CLK_DAVINCI_PLL >>>> +struct clk *davinci_pll_clk(const char *name, const char *parent, >>>> + u32 phys_pllm, u32 phys_prediv, u32 phys_postdiv, >>>> + struct clk_pll_data *pll_data) >>>> +{ >>>> + struct clk *clkp = NULL; >>>> + >>>> + pll_data->reg_pllm = ioremap(phys_pllm, 4); >>>> + if (WARN_ON(!pll_data->reg_pllm)) >>>> + return clkp; >>> I would prefer ERR_PTR(-ENOMEM) here. Same comment applies to other >>> instances elsewhere in the patch. >>> >>>> diff --git a/drivers/clk/davinci/clock.h b/drivers/clk/davinci/clock.h >>>> new file mode 100644 >>>> index 0000000..73204b8 >>>> --- /dev/null >>>> +++ b/drivers/clk/davinci/clock.h >>>> @@ -0,0 +1,80 @@ >>>> +/* >>>> + * TI DaVinci Clock definitions - Contains Macros and Types used for >>>> + * defining various clocks on a DaVinci SoC >>>> + * >>>> + * Copyright (C) 2012 Texas Instruments >>>> + * >>>> + * This program is free software; you can redistribute it and/or >>>> + * modify it under the terms of the GNU General Public License as >>>> + * published by the Free Software Foundation version 2. >>>> + * >>>> + * This program is distributed "as is" WITHOUT ANY WARRANTY of any >>>> + * kind, whether express or implied; without even the implied warranty >>>> + * of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >>>> + * GNU General Public License for more details. >>>> + */ >>>> +#ifndef __DAVINCI_CLOCK_H >>>> +#define __DAVINCI_CLOCK_H >>>> + >>>> +#include <linux/types.h> >>>> + >>>> +/* general flags: */ >>>> +#define ALWAYS_ENABLED BIT(0) >>> This is not used in this patch. Can you add the define along with its >>> usage so it is immediately clear why you need it? >> This is used on the next patch as this adds a bunch of utilities or >> types for the platform specific clock code. Do you want to combine this >> patch with 05/11? It will become a bigger patch then? Is that fine. >> IMO, this is a logical group that can be a standalone patch than >> combining with 05/11. > It is more important to divide patches in logical functional blocks > rather than split it based on files. Reading this patch, I have no idea > what that define is for. > > Thanks, > Sekhar > > Will combine with 05/11 since utilities are used by the clock init code in dm644x. Murali
| |