Messages in this thread | | | Date | Mon, 5 Nov 2012 10:44:50 +0100 | From | Lee Jones <> | Subject | Re: [PATCH 8/9] isdn: Remove unused variable causing a compile build warning |
| |
On Mon, 05 Nov 2012, Paul Bolle wrote:
> On Mon, 2012-11-05 at 09:44 +0100, Lee Jones wrote: > > On Sun, 04 Nov 2012, David Miller wrote: > > > I think the most appropriate thing to do is make CONFIG_ISDN depend > > > upon CONFIG_NETDEVICES in the Kconfig file. > > > > ... and then remove the CONFIG_NETDEVICES guards in isdn_common.c? > > If ISDN would depend on NETDEVICES, ISDN_I4L would too, since it depends > on ISDN. In that case CONFIG_NETDEVICES would always be true when > compiling isdn_common.c. That would make these guards pointless. (The > dependency of ISDN_PPP on NETDEVICES would then also be pointless.)
I'll submit a patch based on your comments.
Thanks for your time Paul.
-- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |