lkml.org 
[lkml]   [2012]   [Nov]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V5] PWM: Add SPEAr PWM chip driver support
On Thu, Oct 25, 2012 at 09:39:13AM +0530, Shiraz Hashim wrote:
> Add support for PWM chips present on SPEAr platforms. These PWM
> chips support 4 channel output with programmable duty cycle and
> frequency.
>
> More details on these PWM chips can be obtained from relevant
> chapter of reference manual, present at following[1] location.
>
> 1. http://www.st.com/internet/mcu/product/251211.jsp
>
> Cc: Thierry Reding <thierry.reding@avionic-design.de>
> Signed-off-by: Shiraz Hashim <shiraz.hashim@st.com>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> Reviewed-by: Vipin Kumar <vipin.kumar@st.com>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> Changes:-
> V4 --> V5:
> * replace tab by space in structure element declaration
> * restructure probe to register pwm_chip at end when clk is prepared, and
> all initializations done.
> * move clk_enable/disable in probe under if block which checks "1340"
> compatibility
> * Replace (ret < 0) if condition by (!ret) at places where ret should be 0
> on success
>
> V3 --> V4:
> * simplify remove
> * maintain alphabetical order in Makefile
> * donot check for device node in probe
> * move few assignment lines in probe
>
> V2 --> V3:
> * remove "disabled" line from pwm dt binding documentation
> * remove un-necessary check on pwm chip (for NULL) in remove.
>
> V1 --> V2:
> * make proper reference to pwm and pwm chip
> * take care to capitalize PWM at appropriate places
> * fix compatible string to the SoC where pwm chip was introduced
> * Rename the documentation file to the name of driver
> * Fix cosmetic changes like names, function name alignment, paragraph
> formating, comments placement and formating, etc.
> * Group and associate the bit field definitions to their registers
> * Fix kerneldoc for structure definition
> * Use chip to name pwm device and pwm for the channel instance
> * Remove init section qualifiers
> * Remove ifdefs around device tree from code and add dependency on CONFIG_OF
> * prepare/unprepare clock once in probe/remove and just enable/disable
> at rest of the places.
> * Use _relaxed for readl/writel.
> * Fix pwm disable part in remove
>
> .../devicetree/bindings/pwm/spear-pwm.txt | 18 ++
> drivers/pwm/Kconfig | 11 +
> drivers/pwm/Makefile | 1 +
> drivers/pwm/pwm-spear.c | 276 ++++++++++++++++++++
> 4 files changed, 306 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/pwm/spear-pwm.txt
> create mode 100644 drivers/pwm/pwm-spear.c

Applied, thanks.

Thierry
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2012-11-05 10:42    [W:0.035 / U:1.716 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site