lkml.org 
[lkml]   [2012]   [Nov]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH][GIT PULL][3.8] x86: Don't clobber top of pt_regs in nested NMI
>>> On 02.11.12 at 20:19, Steven Rostedt <rostedt@goodmis.org> wrote:
> @@ -1842,8 +1851,12 @@ nmi_swapgs:
> SWAPGS_UNSAFE_STACK
> nmi_restore:
> RESTORE_ALL 8
> +
> + /* Pop the extra iret frame */
> + addq $(5*8), %rsp

This could (for code efficiency) and should (for CFI annotation
correctness) be folded into the RESTORE_ALL above (by
converting "8" to "6*8").

Jan

> +
> /* Clear the NMI executing stack variable */
> - movq $0, 10*8(%rsp)
> + movq $0, 5*8(%rsp)
> jmp irq_return
> CFI_ENDPROC
> END(nmi)




\
 
 \ /
  Last update: 2012-11-05 10:42    [W:0.694 / U:0.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site